lkml.org 
[lkml]   [2014]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Fwd: Re: [PATCH v2] input: misc: Add driver for Intel Bay Trail GPIO buttons
On Wed, Apr 16, 2014 at 12:20:01AM +0200, Pavel Machek wrote:
> Hi!
> >
> > Input: misc - Add driver for Intel Bay Trail GPIO buttons
> >
> > From: Lejun Zhu <lejun.zhu@linux.intel.com>
> >
> > This patch adds support for the GPIO buttons on some Intel Bay Trail
> > tablets originally running Windows 8. The ACPI description of these
> > buttons follows "Windows ACPI Design Guide for SoC Platforms".
>
> Hmm. Is it time for x86 to adopt device tree? Because this is 200
> lines of C code which should really have been 10 lines of .dts...
>
> > +
> > +/*
> > + * Some of the buttons like volume up/down are auto repeat, while others
> > + * are not. To support both, we register two platform devices, and put
> > + * buttons into them based on whether the key should be auto repeat.
> > + */
> > +#define BUTTON_TYPES 2
> > +
> > +struct soc_button_data {
> > + struct platform_device *children[BUTTON_TYPES];
> > +};
>
> Would it be possible to extend device description so that this hack is
> not needed?

It would be not that easy as that would mean we need to control
autorepeat (and thus control repeat delay/repeat rate and also report
them) on a per-key basis.

Having 2 separate devices, one offering autorepeat and another not using
it, is much simpler.

Thanks.

--
Dmitry


\
 
 \ /
  Last update: 2014-04-20 22:41    [W:0.054 / U:23.224 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site