Messages in this thread | | | Date | Sun, 20 Apr 2014 12:54:19 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH v2 5/5] PCI: Remove redundant 'quirk_amd_nb_node' |
| |
On Fri, Apr 18, 2014 at 08:53:46PM -0600, Myron Stowe wrote: > With the amd_bus.c updates to support additional AMD processors (11h, 12h, > 14h 15h and 16h) 'quirk_amd_nb_node' seems to be redundant. This patch > removes it. > > Signed-off-by: Myron Stowe <myron.stowe@redhat.com>
Good idea. Has this been tested, though? There are a bunch of places using dev_to_node() which this quirk corrects, especially 'local_cpus' in a bunch of sysfs nodes in the PCI hierarchy /sys/devices/pci*.
We want to make sure this doesn't break that and other dev_to_node() callsites.
Thanks.
-- Regards/Gruss, Boris.
Sent from a fat crate under my desk. Formatting is fine. --
| |