Messages in this thread | | | Subject | Re: [PATCH net-next v2 2/2] xen-netback: Grant copy the header instead of map and memcpy | From | Ian Campbell <> | Date | Wed, 2 Apr 2014 08:29:38 +0100 |
| |
On Tue, 2014-04-01 at 19:55 +0100, Zoltan Kiss wrote: > >> @@ -1389,7 +1393,7 @@ static int xenvif_tx_submit(struct xenvif > *vif) > >> txp = &vif->pending_tx_info[pending_idx].req; > >> > >> /* Check the remap error code. */ > >> - if (unlikely(xenvif_tx_check_gop(vif, skb, &gop_map))) > { > >> + if (unlikely(xenvif_tx_check_gop(vif, skb, &gop_map, > >> &gop_copy))) { > >> netdev_dbg(vif->dev, "netback grant > failed.\n"); > > > > It could have been the copy that failed. You should probably change > the error message. > I've changed it to "netback grant op failed.\n"
Perhaps xenvif_tx_check_gop is in a position to log something more specific about the failure? (maybe it already does, I didn't look).
Ian.
| |