Messages in this thread | | | Date | Fri, 18 Apr 2014 23:51:07 +0400 | From | Sergei Shtylyov <> | Subject | Re: [PATCH v2 2/4] Documentation: dts: Add bindings for APM X-Gene SoC ethernet driver |
| |
Hello.
On 04/12/2014 07:06 AM, Iyappan Subramanian wrote:
> This patch adds documentation for APM X-Gene SoC ethernet DTS binding.
> Signed-off-by: Iyappan Subramanian <isubramanian@apm.com> > Signed-off-by: Ravi Patel <rapatel@apm.com> > Signed-off-by: Keyur Chudgar <kchudgar@apm.com> > --- > .../devicetree/bindings/net/apm-xgene-enet.txt | 46 ++++++++++++++++++++ > 1 file changed, 46 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/apm-xgene-enet.txt
> diff --git a/Documentation/devicetree/bindings/net/apm-xgene-enet.txt b/Documentation/devicetree/bindings/net/apm-xgene-enet.txt > new file mode 100644 > index 0000000..0c983e8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/apm-xgene-enet.txt > @@ -0,0 +1,46 @@ > +APM X-Gene SoC Ethernet nodes > + > +Ethernet nodes are defined to describe on-chip ethernet interfaces in > +APM X-Gene SoC. > + > +Required properties: > +- compatible : Should be "apm,xgene-enet" > +- reg : First resource is the ethernet base register set > + Second resource is the ring base register set > + Third resource is the ring command register set > +- interrupts : Ethernet main interrupt > +- clocks : Reference to the clock entry. > +- local-mac-address : Ethernet MAC address.
This property is described in Documentation/devicetree/bindings/net/ethernet.txt, please refer to it.
> +- phy-addr : Ethernet MII phy address.
No, thus won't do. Please use "phy-handle" property to refer to a PHY subnode.
> +- phy-mode : Ethernet MII mode.
This one is described in Documentation/devicetree/bindings/net/ethernet.txt as well.
WBR, Sergei
| |