lkml.org 
[lkml]   [2014]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/8] idr: covert BUG_ON() to WARN_ON_ONCE() if the argument is invalid.
On Fri, Apr 18, 2014 at 08:49:52PM +0800, Lai Jiangshan wrote:
> @@ -1135,7 +1136,7 @@ void ida_simple_remove(struct ida *ida, unsigned int id)
> {
> unsigned long flags;
>
> - BUG_ON((int)id < 0);
> + WARN_ON_ONCE((int)id < 0);

Shouldn't this be moved to ida_remove()? Also, it probably should
return afterwards?

Thanks.

--
tejun


\
 
 \ /
  Last update: 2014-04-18 19:41    [W:0.060 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site