lkml.org 
[lkml]   [2014]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/2] regmap: i2c: fallback to SMBus if the adapter does not support standard I2C
On Thu, Apr 17, 2014 at 11:40:12AM +0200, Boris BREZILLON wrote:

> +const struct regmap_bus *regmap_get_i2c_bus(struct i2c_client *i2c,
> + const struct regmap_config *config)

Non-exported functions should be static. Otherwise this looks good
modulo the register size issue that Guenter identified.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2014-04-18 18:01    [W:0.730 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site