Messages in this thread | | | Date | Thu, 17 Apr 2014 11:29:32 -0400 | From | Tejun Heo <> | Subject | Re: [PATCH] workqueue: add __WQ_FREEZING and remove POOL_FREEZING |
| |
On Thu, Apr 17, 2014 at 07:58:55AM +0800, Lai Jiangshan wrote: > > Why are we removing the above? Can't we still test __WQ_FREEZING as > > we're holding wq->mutex? I don't really mind removing the > > optimization but the patch description at least has to explain what's > > going on. > > This part was in other old patch: https://lkml.org/lkml/2013/4/3/756 > I admit the changelogs(old patch&this) are bad. > But I still consider it would be better if we split it to two patches: > (https://lkml.org/lkml/2013/4/3/748 & https://lkml.org/lkml/2013/4/3/756) > > There are different aims in the patches. > > Any thinks? And sorry for I didn't keep to push the patches at that time.
Yeah, I think I like the changes. Please split them and send with proper descriptions.
Thanks.
-- tejun
| |