Messages in this thread | | | Date | Thu, 17 Apr 2014 07:57:53 +0100 | From | Lee Jones <> | Subject | Re: [PATCH 2/4] mfd: bcm590xx: add support for second i2c slave address space |
| |
> > s/regmap/Regmap > > It's consistently written regmap in all the documentation and so on :)
Furry muff; but the comments still stand for the acronyms.
> > addmap{0,1} doesn't quite sit right with me. > > > REVISIT: Ah, it's address-map, rather than add map. Okay, not as bad > > as I first thought, but still, is there a better naming convention you > > could use? > > addrmap or something?
Right, that was what I was thinking. However, I prefer something along the lines of 'i2c' and 'i2c_sec' or 'client' and 'client_slv' etc.
-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |