Messages in this thread | | | Date | Thu, 17 Apr 2014 09:19:18 -0400 | From | Tejun Heo <> | Subject | Re: [PATCH] kernfs: fix a subdir count leak |
| |
On Thu, Apr 17, 2014 at 05:52:10PM +0800, Jianyu Zhan wrote: > Currently kernfs_link_sibling() increates parent->dir.subdirs before > adding the node into parent's chidren rb tree. > > Because it is possible that kernfs_link_sibling() couldn't find > a suitable slot and bail out, this leads to a mismatch between > elevated subdir count with actual children node numbers. > > This patches fix this problem, by moving the subdir accouting > after the actual addtion happening. > > Signed-off-by: Jianyu Zhan <nasa4836@gmail.com>
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
-- tejun
| |