Messages in this thread | | | Subject | Re: [DRIVER CORE] drivers/base/dd.c incorrect pr_debug() parameters | From | Joe Perches <> | Date | Wed, 16 Apr 2014 18:23:05 -0700 |
| |
On Wed, 2014-04-16 at 18:12 -0700, Frank Rowand wrote: > On 4/16/2014 5:48 PM, Joe Perches wrote: > > On Wed, 2014-04-16 at 17:12 -0700, Frank Rowand wrote: > >> pr_debug() parameters are reverse order of format string > > > > Another way to do this might be to change all the > > printks/pr_debugs to dev_<level> > > Yes, but if that is done, one may as well do all of drivers/base/*.c > and drivers/base/*/*.c
Actually, I don't think so, no.
These are the ones that have a struct device attached to them. Many of the others are device free and are prefixed differently, like power and devtmpfs and bus.
> I was only trying to fix incorrectly reported information from one > pr_debug(). If someone else want to do a big conversion, they are > free to. :-)
Always true...
cheers, Joe
| |