lkml.org 
[lkml]   [2014]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] kernel/rcu/rcutorture.c: use macro to define module parameter
On Wed, Apr 16, 2014 at 04:47:39PM -0400, Pranith Kumar wrote:
> use the defined macro for module parameter definition
>
> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>

This fails for me. The problem is that the defined macro makes everything
static, and rcutorture_runnable is used in kernel/sysctl.c. :-/

In theory, it would be possible to make torture_param() take "static"
as a parameter, but this adds more characters than it removes.

Thanx, Paul

> ---
> kernel/rcu/rcutorture.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c
> index bd30bc6..1a0298c 100644
> --- a/kernel/rcu/rcutorture.c
> +++ b/kernel/rcu/rcutorture.c
> @@ -143,9 +143,8 @@ static struct list_head rcu_torture_removed;
> #else
> #define RCUTORTURE_RUNNABLE_INIT 0
> #endif
> -int rcutorture_runnable = RCUTORTURE_RUNNABLE_INIT;
> -module_param(rcutorture_runnable, int, 0444);
> -MODULE_PARM_DESC(rcutorture_runnable, "Start rcutorture at boot");
> +torture_param(int, rcutorture_runnable, RCUTORTURE_RUNNABLE_INIT,
> + "Start rcutorture at boot");
>
> #if defined(CONFIG_RCU_BOOST) && !defined(CONFIG_HOTPLUG_CPU)
> #define rcu_can_boost() 1
> --
> 1.7.9.5
>



\
 
 \ /
  Last update: 2014-04-16 23:41    [W:0.048 / U:0.320 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site