Messages in this thread | | | Date | Wed, 16 Apr 2014 14:00:44 -0400 | From | Joseph Salisbury <> | Subject | Re: [PATCH 1/1] powerpc: Increase COMMAND_LINE_SIZE to 2048 from 512. |
| |
On 04/15/2014 05:49 AM, Benjamin Herrenschmidt wrote: > On Mon, 2014-04-14 at 14:58 -0400, Joseph Salisbury wrote: >> After further review, it appears ppc does not actually use the define >> in >> the ppc headers but uses the common generic >> default(include/uapi/asm-generic/setup.h). COMMAND_LINE_SIZE should >> probably become a kernel config option. Do folks agree that is the >> correct thing to do? If so, I can re-work the patch. > No objection on my side. > > Make sure you remove any unused arch define while at it. > > Cheers, > Ben. > > Hi Ben,
I can think of two ways to add the new config option. One would be to have a large entry in ~/arch/Kconfig, with a default COMMAND_LINE_SIZE line for each architecture. The other way would be to have the default value for COMMAND_LINE_SIZE in the architecture sub-directory Kconfig file: ~/arch/powerpc/Kconfig for example.
Do you have a preference for either way?
Thanks,
Joe
| |