Messages in this thread | | | Date | Wed, 16 Apr 2014 10:45:03 -0600 | From | Jens Axboe <> | Subject | Re: [PATCH 2/8] blk-mq: bidi support |
| |
On 04/16/2014 10:44 AM, Christoph Hellwig wrote: > On Wed, Apr 16, 2014 at 10:41:30AM -0600, Jens Axboe wrote: >>> - if (!q->request_fn) >>> + if (!q->request_fn && !q->mq_ops) >>> return 0; >>> >>> bcd = &q->bsg_dev; >> >> This looks misplaced. But I dropped the one I generated last week, I'll >> queue it up separately in the drivers branch. > > Could be argued that it should be a separate patch, but the check should > work fine.
There's nothing wrong with the check, it's identical to one I sent out last week. But it's not part of the bidi enable patch, it's a separate bug fix for bsg.
-- Jens Axboe
| |