lkml.org 
[lkml]   [2014]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] mfd: tps65090: Stop caching registers
> Nearly all of the registers in tps65090 combine control bits and
> status bits. Turn off caching of registers so that we can read status
> bits reliably.
>
> NOTE: the IRQnMASK and CG_CTRLn registers are the exception and could
> be cached. If we find that we spend a lot of time reading those we
> can turn on cache for just those registers.
>
> Signed-off-by: Doug Anderson <dianders@chromium.org>
> ---
> drivers/mfd/tps65090.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/drivers/mfd/tps65090.c b/drivers/mfd/tps65090.c
> index c3cddb4..4cfdd07 100644
> --- a/drivers/mfd/tps65090.c
> +++ b/drivers/mfd/tps65090.c
> @@ -149,21 +149,11 @@ static struct regmap_irq_chip tps65090_irq_chip = {
> .mask_invert = true,
> };
>
> -static bool is_volatile_reg(struct device *dev, unsigned int reg)
> -{
> - if ((reg == TPS65090_INT_STS) || (reg == TPS65090_INT_STS2))
> - return true;
> - else
> - return false;
> -}
> -

I don't know enough about Regmap internals to know what this actually
affects in real terms.

Mark,
Does this change seem sane to you?

> static const struct regmap_config tps65090_regmap_config = {
> .reg_bits = 8,
> .val_bits = 8,
> .max_register = TOTAL_NUM_REG,
> .num_reg_defaults_raw = TOTAL_NUM_REG,
> - .cache_type = REGCACHE_RBTREE,
> - .volatile_reg = is_volatile_reg,
> };
>
> #ifdef CONFIG_OF

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2014-04-16 12:21    [W:0.014 / U:44.280 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site