lkml.org 
[lkml]   [2014]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 00/20] Introduce new cpufreq helper macros
On 15/04/2014 09:01 πμ, Viresh Kumar wrote:
> On 15 April 2014 02:37, Stratos Karafotis <stratosk@semaphore.gr> wrote:
>> This patch set introduces two freq_table helper macros which
>> can be used for iteration over cpufreq_frequency_table and
>> makes the necessary changes to cpufreq core and drivers that
>> use such an iteration procedure.
>>
>> The motivation was a usage of common procedure to iterate over
>> cpufreq_frequency_table across all drivers and cpufreq core.
>>
>> This was tested on a x86_64 platform.
>> Patches 4-17 compiled successfully but unfortunately I was not
>> able to compile test patches 18-20.
>
> Mostly okay, just some Nitpicks..
>
> Please rearrange your patches this way:
> - First patch just adds the wrappers
> - Second one makes changes to drivers/cpufreq/, i.e. include all core
> and drivers
> changes into a single patch here as the logs are exactly same.
> - Then framework by framework, as we may need Acks/Reviews by them
> separately..
>
> So, probably just 5-7 would do.
>


Thanks for your review and your corrections!
I will prepare and send the v2 according to your suggestions.

Stratos
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2014-04-16 09:41    [W:0.035 / U:15.768 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site