lkml.org 
[lkml]   [2014]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2] mm: convert some level-less printks to pr_*
Date
On Mon, Apr 14 2014 at 03:55:26 PM, Andrew Morton <akpm@linux-foundation.org> wrote:
> On Thu, 27 Mar 2014 10:54:19 -0700 Mitchel Humpherys <mitchelh@codeaurora.org> wrote:
>> #include <linux/mm.h>
>> #include <linux/export.h>
>> #include <linux/swap.h>
>> @@ -15,6 +17,7 @@
>> #include <linux/hash.h>
>> #include <linux/highmem.h>
>> #include <linux/bootmem.h>
>> +#include <linux/printk.h>
>> #include <asm/tlbflush.h>
>>
>> #include <trace/events/block.h>
>> @@ -34,7 +37,7 @@ static __init int init_emergency_pool(void)
>>
>> page_pool = mempool_create_page_pool(POOL_SIZE, 0);
>> BUG_ON(!page_pool);
>> - printk("bounce pool size: %d pages\n", POOL_SIZE);
>> + pr_info("bounce pool size: %d pages\n", POOL_SIZE);
>
> This used to print "bounce pool size: N pages" but will now print
> "bounce: bounce pool size: N pages".
>
> It isn't necessarily a *bad* change but perhaps a little more thought
> could be put into it. In this example it would be better remove the
> redundancy by using
>
> pr_info("pool size: %d pages\n"...);

Yes I noticed this in my boot-test... I'll change it to remove the
redundancy. The others all seem okay.

>
> And all of this should be described and justified in the changelog,
> please.

Will send a v3 shortly. Thanks for your comments.

--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation


\
 
 \ /
  Last update: 2014-04-16 02:21    [W:0.078 / U:14.860 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site