lkml.org 
[lkml]   [2014]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mfd: mc13xxx-core: Initialize the lock prior to using it
On Tue, Apr 15, 2014 at 07:43:10PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> After request_threaded_irq() is called there is a chance that an interrupt
> may occur before the 'mc13xxx->lock' is initialized, which will trigger a kernel
> warning.

I'd suggest... "which will trigger a kernel oops" because that's what
you got - it killed the IRQ thread, which then caused a few other
problems along the way.

> In order to prevent that, move the initialization of 'mc13xxx->lock' prior to
> requesting the interrupts.
>
> Suggested-by: Russell King <rmk+kernel@arm.linux.org.uk>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Patch looks good, and should fix the reported issue... so with the above
description fixed,

Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>

Thanks.

--
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.


\
 
 \ /
  Last update: 2014-04-16 01:21    [W:0.029 / U:7.216 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site