lkml.org 
[lkml]   [2014]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/1] Drivers/PCI: Logging clean-up [1]
From
Date
On Tue, 2014-04-15 at 20:55 +0200, Fabian Frederick wrote:

> diff --git a/drivers/pci/pci-stub.c b/drivers/pci/pci-stub.c
[]
> @@ -15,7 +15,7 @@
> * # ls -l /sys/bus/pci/devices/0000:00:19.0/driver
> * .../0000:00:19.0/driver -> ../../../bus/pci/drivers/pci-stub
> */
> -
> +#define pr_fmt(fmt) "pci-stub: " fmt

When the output prefix matches the module/filename, please use

#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

[]

> diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
[]
> @@ -903,8 +903,8 @@ legacy_io_err:
> kfree(b->legacy_io);
> b->legacy_io = NULL;
> kzalloc_err:
> - printk(KERN_WARNING "pci: warning: could not create legacy I/O port "
> - "and ISA memory resources to sysfs\n");
> + pr_warn("warning: could not create legacy I/O port "
> + "and ISA memory resources to sysfs\n");

Please coalesce format fragments too even if the format part
exceeds 80 columns.




\
 
 \ /
  Last update: 2014-04-15 22:21    [W:0.032 / U:7.924 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site