[lkml]   [2014]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH -mm 1/4] memcg, slab: do not schedule cache destruction when last page goes away
On Tue, 15 Apr 2014, Vladimir Davydov wrote:

> > There is already logic in both slub and slab that does that on cache
> > close.
> Yeah, but here the question is when we should close caches left after memcg
> offline. Obviously we should do it after all objects of such a cache have
> gone, but when exactly? Do it immediately after the last kfree (have to count
> objects per cache then AFAIU) or may be check periodically (or on vmpressure)
> that the cache is empty by issuing kmem_cache_shrink and looking if
> memcg_params::nr_pages = 0?

Guess check once in a while if you have no other way to determine this. A
hook in kfree() would impact all users.

 \ /
  Last update: 2014-04-15 22:01    [W:0.035 / U:4.304 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site