lkml.org 
[lkml]   [2014]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v5 1/6] SP800-90A Deterministic Random Bit Generator
Date
Am Montag, 14. April 2014, 22:51:05 schrieb Joe Perches:

Hi Joe,

> On Tue, 2014-04-15 at 07:35 +0200, Stephan Mueller wrote:
> > diff --git a/crypto/drbg.c b/crypto/drbg.c
>
> []
>
> > @@ -0,0 +1,1997 @@
>
> []
>
> > +/***************************************************************
> > + * Backend cipher definitions available to DRBG
> > + ***************************************************************/
> > +
> > +const struct drbg_core cores[] = {
>
> cores isn't a very good global name.
> I presume this should be static.

Agreed. static added and renamed to drbg_cores. I will wait a few days before
releasing a new version. Maybe other comments show up.

Thanks for the review.

Ciao
Stephan
--
| Cui bono? |


\
 
 \ /
  Last update: 2014-04-15 08:41    [W:0.057 / U:0.484 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site