Messages in this thread | | | Date | Tue, 15 Apr 2014 12:47:52 -0400 | From | Tejun Heo <> | Subject | Re: [PATCH V2] workqueue: fix possible race condition when rescuer VS pwq-release |
| |
On Fri, Mar 28, 2014 at 08:07:58PM +0800, Lai Jiangshan wrote: > +static inline void get_unbound_pwq(struct pool_workqueue *pwq) > +{ > + if (pwq->wq->flags & WQ_UNBOUND) > + get_pwq(pwq); > +} > + > /** > * put_pwq - put a pool_workqueue reference > * @pwq: pool_workqueue to put > @@ -1075,6 +1081,12 @@ static void put_pwq(struct pool_workqueue *pwq) > schedule_work(&pwq->unbound_release_work); > } > > +static inline void put_unbound_pwq(struct pool_workqueue *pwq) > +{ > + if (pwq->wq->flags & WQ_UNBOUND) > + put_pwq(pwq); > +}
Ugh... please drop these helpers.
> + get_unbound_pwq(pwq);
Why not just do get_pwq() here?
Thanks.
-- tejun
| |