lkml.org 
[lkml]   [2014]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 14/20] thermal: cpu_cooling: Use cpufreq_for_each_valid_entry macro for iteration
From
On 15 April 2014 02:40, Stratos Karafotis <stratosk@semaphore.gr> wrote:
> The cpufreq core supports the cpufreq_for_each_valid_entry macro
> helper for iteration over the cpufreq_frequency_table, so use it.
>
> It should have no functional changes.
>
> Signed-off-by: Stratos Karafotis <stratosk@semaphore.gr>
> ---
> drivers/thermal/cpu_cooling.c | 33 +++++++++++++--------------------
> 1 file changed, 13 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c
> index 4246262..3040629 100644
> --- a/drivers/thermal/cpu_cooling.c
> +++ b/drivers/thermal/cpu_cooling.c
> @@ -144,11 +144,11 @@ static int get_property(unsigned int cpu, unsigned long input,
> unsigned int *output,
> enum cpufreq_cooling_property property)
> {
> - int i, j;
> + int i;
> unsigned long max_level = 0, level = 0;
> unsigned int freq = CPUFREQ_ENTRY_INVALID;
> int descend = -1;
> - struct cpufreq_frequency_table *table =
> + struct cpufreq_frequency_table *pos, *table =
> cpufreq_frequency_get_table(cpu);
>
> if (!output)
> @@ -157,20 +157,16 @@ static int get_property(unsigned int cpu, unsigned long input,
> if (!table)
> return -EINVAL;
>
> - for (i = 0; table[i].frequency != CPUFREQ_TABLE_END; i++) {
> - /* ignore invalid entries */
> - if (table[i].frequency == CPUFREQ_ENTRY_INVALID)
> - continue;
> -
> + cpufreq_for_each_valid_entry(pos, table) {
> /* ignore duplicate entry */
> - if (freq == table[i].frequency)
> + if (freq == pos->frequency)
> continue;
>
> /* get the frequency order */
> if (freq != CPUFREQ_ENTRY_INVALID && descend == -1)
> - descend = !!(freq > table[i].frequency);
> + descend = !!(freq > pos->frequency);

drop !! as well, its not required here. Mention that in log.


\
 
 \ /
  Last update: 2014-04-15 08:41    [W:0.032 / U:57.900 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site