lkml.org 
[lkml]   [2014]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 1/2] regulator: pbias: Fix is_enabled callback implementation
From
2014-04-15 5:16 GMT+08:00 Mark Brown <broonie@kernel.org>:
> On Sat, Mar 08, 2014 at 11:55:29AM +0800, Axel Lin wrote:
>> The is_enabled implementation is wrong in some cases:
>> e.g. for pbias_mmc_omap5: enable_mask is : BIT(27) | BIT(25) | BIT(26)
>> However, pbias_regulator_enable() only sets BIT(27) | BIT(26) bits.
>> So is_enabled callback will always return false in this case.
>> Fix the logic to compare the register value with info->enable rather than
>> info->enable_mask.
>
> Applied both, thanks.

Hi Mark,
Currently these 2 commits are in topic/pbias branch.

I think commit 1cb7b43f6796
"regulator: pbias: Fix is_enabled callback implementation"
is a bug fix for 3.15.

commit 60e8c1e34d3a
"regulator: pbias: Convert to use regmap helper functions"
might also required for 3.15.
The reason is this commit implements .list_voltage and the mmc core calls
regulator_list_voltage() in mmc_regulator_get_ocrmask().

Regards,
Axel


\
 
 \ /
  Last update: 2014-04-15 17:41    [W:0.106 / U:3.916 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site