Messages in this thread | | | From | Namhyung Kim <> | Subject | Re: [PATCH] perf machine: Search for modules in %s/lib/modules/%s | Date | Tue, 15 Apr 2014 14:44:52 +0900 |
| |
Hi Richard,
On Thu, 10 Apr 2014 12:52:59 -0400, Richard Yao wrote: > Modules installed outside of the kernel's build system should go into > "%s/lib/modules/%s/extra", but at present, perf will only look at them > when they are in "%s/lib/modules/%s/kernel". Lets encourage good > citizenship by relaxing this requirement to "%s/lib/modules/%s". This > way open source modules that are out-of-tree have no incentive to start > populating a directory reserved for in-kernle modules and I can stop hex > editing my system's perf binary when profiling OSS out-of-tree modules.
But it'll make the perf traverses all the source and build directories too, right? I don't think it's a right thing to do.
Maybe we can also change stat() in map_groups__set_modules_path_dir() to lstat() so that it cannot go to unwanted directories in that case. Or else, just checking "kernel" and "extra" directories will work.
Thanks, Namhyung
| |