lkml.org 
[lkml]   [2014]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] kprobes: be more permissive when user specifies both symbol name and address
On Mon, Apr 14, 2014 at 11:00 PM, Masami Hiramatsu
<masami.hiramatsu.pt@hitachi.com> wrote:
> if (p->addr) {
> if (p->symbol) {
> sym = kallsyms_lookup(p->addr, ... &offs ...);
> if (strcmp(sym,p->symbol) != 0 || offs != p->offset) {
> pr_warning("Error! ...");
> goto fail;
> }
> }
> } else if (p->symbol) {
> kprobe_lookup_name(p->symbol_name, addr);
> if (!addr)
> goto fail;
> } else
> goto fail;


Hmm, let's clasify all conditions.

1. Only symbol, check it, if not found, fail.
2. Only address, check it, if not found, fail.
3. Both, check address,
3.1 not found, fail, because some symbols might have muplitple instances,
we don't bother to check symbol name.
3.2 found, check if symbol mismatch, if yes, fail.


Is this reasonable? Next mail is a renewed patch following this priciple.


Regards,
Jianyu Zhan


\
 
 \ /
  Last update: 2014-04-15 15:41    [W:0.063 / U:38.916 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site