lkml.org 
[lkml]   [2014]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v3 5/5] acpi_processor: do not mark present at boot but not onlined CPU as onlined
Date
On Monday, April 14, 2014 11:21:47 AM Ingo Molnar wrote:
>
> * Igor Mammedov <imammedo@redhat.com> wrote:
>
> > acpi_processor_add() assumes that present at boot CPUs
> > are always onlined, it is not so if a CPU failed to become
> > onlined. As result acpi_processor_add() will mark such CPU
> > device as onlined in sysfs and following attempts to
> > online/offline it using /sys/device/system/cpu/cpuX/online
> > attribute will fail.
> >
> > Do not poke into device internals in acpi_processor_add()
> > and touch "struct device { .offline }" attribute, since
> > for CPUs onlined at boot it's set by:
> > topology_init() -> arch_register_cpu() -> register_cpu()
> > before ACPI device tree is parsed, and for hotplugged
> > CPUs it's set when userspace onlines CPU via sysfs.
> >
> > Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> > ---
> > drivers/acpi/acpi_processor.c | 3 ---
> > 1 files changed, 0 insertions(+), 3 deletions(-)
>
> Can this fix be moved first too, or does it have undesirable side
> effects on unmodified kernels?

This patch is not correct.

Rafael



\
 
 \ /
  Last update: 2014-04-15 08:21    [W:0.166 / U:8.072 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site