lkml.org 
[lkml]   [2014]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 4/4] regulator: s5m8767: Use same binding for external control as in s2mps11
From
Date
On wto, 2014-04-15 at 13:26 +0530, Sachin Kamat wrote:
> On 15 April 2014 02:41, Mark Brown <broonie@kernel.org> wrote:
> > On Mon, Apr 14, 2014 at 10:09:09AM +0200, Krzysztof Kozlowski wrote:
> >
> >> - - s5m8767,pmic-ext-control-gpios: (optional) GPIO specifier for one
> >> + - samsung,ext-control-gpios: (optional) GPIO specifier for one
> >> GPIO controlling this regulator (enable/disable); This is
> >> valid only for buck9.
> >
> > This is an incompatible change. It's OK to deprecate the old property
> > but it's bad form to just remove it.
>
> I agree with Mark. Also, there is no need to make it generic.

I thought it would be good to make it consistent and to reduce the
number of bindings with same meaning on similar drivers. However I don't
mind skipping this patch.

Thanks for applying rest of patches.

Best regards,
Krzysztof



\
 
 \ /
  Last update: 2014-04-15 12:41    [W:0.032 / U:4.472 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site