lkml.org 
[lkml]   [2014]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V5.1] serial/uart/8250: Add tunable RX interrupt trigger I/F of FIFO buffers

> +static int convert_val2rxtrig(struct uart_8250_port *up, unsigned char val)
> +{
> + const struct serial8250_config *conf_type = &uart_config[up->port.type];
> + int i;
> +
> + if (!conf_type->rx_trig_byte[FCR_RX_TRIG_BITS(UART_FCR_R_TRIG_00)]) {
> + pr_info("Not support RX-trigger setting for this serial %s\n",
> + conf_type->name);
> + return -EOPNOTSUPP;

We don't want the pr_info here - otherwise users can flood the logs. The
err code is sufficient.

> + for (i = 1; i < FCR_RX_TRIG_MAX_STATE; i++) {
> + if (val < conf_type->rx_trig_byte[i])
> + /* Use the nearest lower value */
> + return (--i) << FCR_RX_TRIG_OFFSET;

Odd case here - your 16654 entry has a minimum of 8 so if I pass 1 then
it'll return -1 ? I guess for that case the best we can do is to set 8.

Other trivial thing to tweak - you have "uaser" in spot instead of "user".

With those two fixed it looks good to me.

Alan


\
 
 \ /
  Last update: 2014-04-15 12:41    [W:0.048 / U:1.504 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site