lkml.org 
[lkml]   [2014]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] ARM: dts: berlin: add GPIO nodes for the BG2Q
Sebastian,

On Tue, Apr 15, 2014 at 11:23:03AM +0200, Sebastian Hesselbarth wrote:
> On 04/15/2014 10:07 AM, Antoine Ténart wrote:

[…]

> >diff --git a/arch/arm/boot/dts/berlin2q.dtsi b/arch/arm/boot/dts/berlin2q.dtsi
> >index e6e556055dfc..b2625f896bc5 100644
> >--- a/arch/arm/boot/dts/berlin2q.dtsi
> >+++ b/arch/arm/boot/dts/berlin2q.dtsi
> >@@ -109,6 +109,78 @@
> > ranges = <0 0xe80000 0x10000>;
> > interrupt-parent = <&aic>;
> >
> >+ gpio0: gpio@0400 {
> >+ compatible = "snps,dw-apb-gpio";
> >+ reg = <0x0400 0x400>;
> >+ #address-cells = <1>;
> >+ #size-cells = <0>;
> >+
> >+ porta: gpio-controller@0 {
>
> ePAPR recommended name is even more generic, i.e. "gpio". If
> that clashed in any way with other numbered names, I suggest
> to rename to "gpio-port" as actually the controller is the
> parent node and this represents one port (in the nomenclature
> of DW-APB-GPIO).

I followed the dwapb GPIO binding documentation, but I think this is a good
idea. I'll update.

> >+ compatible = "snps,dw-apb-gpio-port";
> >+ gpio-controller;
> >+ #gpio-cells = <2>;
> >+ snps,nr-gpios = <32>;
>
> 32 gpio pins for each of the 6 GPIO controllers? Either BG2Q is a GPIO
> beast or it is a mistake :P
>
> Can you please double-check?

Maybe Jisheng can confirm this.

> I am fine with using nr-gpios property now, but I guess BG2Q also
> has that CONFIG[1,2] registers to actually read out the features
> synthesized in? If I find some time, I'll prepare a patch for
> dw-apb-gpio to exploit that (optional) information instead of
> using nr-gpios.

Maybe, that would be nice.


Antoine

> Otherwise,
>
> Acked-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
>
> >+ reg = <0>;
> >+ interrupt-controller;
> >+ #interrupt-cells = <2>;
> >+ interrupts = <0>;
> >+ };
> >+ };
> >+
> >+ gpio1: gpio@0800 {
> >+ compatible = "snps,dw-apb-gpio";
> >+ reg = <0x0800 0x400>;
> >+ #address-cells = <1>;
> >+ #size-cells = <0>;
> >+
> >+ portb: gpio-controller@1 {
> >+ compatible = "snps,dw-apb-gpio-port";
> >+ gpio-controller;
> >+ #gpio-cells = <2>;
> >+ snps,nr-gpios = <32>;
> >+ reg = <0>;
> >+ interrupt-controller;
> >+ #interrupt-cells = <2>;
> >+ interrupts = <1>;
> >+ };
> >+ };
> >+
> >+ gpio2: gpio@0c00 {
> >+ compatible = "snps,dw-apb-gpio";
> >+ reg = <0x0c00 0x400>;
> >+ #address-cells = <1>;
> >+ #size-cells = <0>;
> >+
> >+ portc: gpio-controller@2 {
> >+ compatible = "snps,dw-apb-gpio-port";
> >+ gpio-controller;
> >+ #gpio-cells = <2>;
> >+ snps,nr-gpios = <32>;
> >+ reg = <0>;
> >+ interrupt-controller;
> >+ #interrupt-cells = <2>;
> >+ interrupts = <2>;
> >+ };
> >+ };
> >+
> >+ gpio3: gpio@1000 {
> >+ compatible = "snps,dw-apb-gpio";
> >+ reg = <0x1000 0x400>;
> >+ #address-cells = <1>;
> >+ #size-cells = <0>;
> >+
> >+ portd: gpio-controller@3 {
> >+ compatible = "snps,dw-apb-gpio-port";
> >+ gpio-controller;
> >+ #gpio-cells = <2>;
> >+ snps,nr-gpios = <32>;
> >+ reg = <0>;
> >+ interrupt-controller;
> >+ #interrupt-cells = <2>;
> >+ interrupts = <3>;
> >+ };
> >+ };
> >+
> > timer0: timer@2c00 {
> > compatible = "snps,dw-apb-timer";
> > reg = <0x2c00 0x14>;
> >@@ -181,6 +253,36 @@
> > interrupt-parent = <&gic>;
> > interrupts = <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>;
> > };
> >+
> >+ gpio4: gpio@5000 {
> >+ compatible = "snps,dw-apb-gpio";
> >+ reg = <0x5000 0x400>;
> >+ #address-cells = <1>;
> >+ #size-cells = <0>;
> >+
> >+ porte: gpio-controller@4 {
> >+ compatible = "snps,dw-apb-gpio-port";
> >+ gpio-controller;
> >+ #gpio-cells = <2>;
> >+ snps,nr-gpios = <32>;
> >+ reg = <0>;
> >+ };
> >+ };
> >+
> >+ gpio5: gpio@c000 {
> >+ compatible = "snps,dw-apb-gpio";
> >+ reg = <0xc000 0x400>;
> >+ #address-cells = <1>;
> >+ #size-cells = <0>;
> >+
> >+ portf: gpio-controller@5 {
> >+ compatible = "snps,dw-apb-gpio-port";
> >+ gpio-controller;
> >+ #gpio-cells = <2>;
> >+ snps,nr-gpios = <32>;
> >+ reg = <0>;
> >+ };
> >+ };
> > };
> >
> > pinctrl: pinctrl@0 {
> >
>

--
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2014-04-15 12:01    [W:0.081 / U:16.172 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site