lkml.org 
[lkml]   [2014]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] staging: comedi: addi_apci_1564: remove use of devpriv->iobase
On 2014-04-15 06:53, Chase Southwood wrote:
> devpriv->iobase is currently being used to hold the iobase address used to
> read/write the board's registers. The same address is stored in the
> comedi_device dev->iobase. We use that instead. The eventual goal is to
> decrease the driver's use of the struct addi_private, so that it may
> eventually use a much slimmer specialized private struct instead, as the
> other addi_apci_* drivers do.
>
> Signed-off-by: Chase Southwood <chase.southwood@yahoo.com>
> Cc: H Hartley Sweeten <hsweeten@visionengravers.com>
> ---
> This is a (small) first patchset for my more complete cleanup of
> addi_apci_1564 driver. Hartley, I'd appreciate any review you have
> wrt these specific patches, but also whether I have chosen a good place
> to start.

Reviewed-by: Ian Abbott <abbotti@mev.co.uk>

--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-


\
 
 \ /
  Last update: 2014-04-15 11:41    [W:0.077 / U:2.572 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site