lkml.org 
[lkml]   [2014]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 4/4] regulator: s5m8767: Use same binding for external control as in s2mps11
From
On 15 April 2014 02:41, Mark Brown <broonie@kernel.org> wrote:
> On Mon, Apr 14, 2014 at 10:09:09AM +0200, Krzysztof Kozlowski wrote:
>
>> - - s5m8767,pmic-ext-control-gpios: (optional) GPIO specifier for one
>> + - samsung,ext-control-gpios: (optional) GPIO specifier for one
>> GPIO controlling this regulator (enable/disable); This is
>> valid only for buck9.
>
> This is an incompatible change. It's OK to deprecate the old property
> but it's bad form to just remove it.

I agree with Mark. Also, there is no need to make it generic.

--
With warm regards,
Sachin


\
 
 \ /
  Last update: 2014-04-15 11:21    [W:0.239 / U:14.392 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site