Messages in this thread | | | Date | Tue, 15 Apr 2014 10:26:58 +0800 | From | Nicolin Chen <> | Subject | Re: [PATCH v2 1/2] ASoC: fsl_sai: Add clock controls for SAI |
| |
On Mon, Apr 14, 2014 at 09:43:31PM +0100, Mark Brown wrote: > On Wed, Apr 02, 2014 at 06:10:19PM +0800, Nicolin Chen wrote: > > > -- clock-names : Must include the "sai" entry. > > +- clock-names : Must include the "bus" for register access and "mclk1" "mclk2" > > + "mclk3" for bit clock and frame clock providing. > > This breaks compatibilty with old DTs - it just removes the "sai" name. > It's OK to deprecate the "sai" clock name but you need to keep support > for DTs that only specify that, there's no code for that left in the > driver.
Sir, you've already applied the v6 of this patch last week :) And I can still find it in topic/fsl-sai.
ca3e35c ASoC: fsl_sai: Add clock controls for SAI
And regarding the old DTs compatibilty, Shawn has already reminded me in his comments against one of the version. I took his advice and made the patch compatible with the old 'sai' clock binding within that v6.
Thank you, Nicolin
| |