lkml.org 
[lkml]   [2014]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] mm: convert some level-less printks to pr_*
On Thu, 27 Mar 2014 10:54:19 -0700 Mitchel Humpherys <mitchelh@codeaurora.org> wrote:

> printk is meant to be used with an associated log level. There are some
> instances of printk scattered around the mm code where the log level is
> missing. Add a log level and adhere to suggestions by
> scripts/checkpatch.pl by moving to the pr_* macros.
>

hm, this is a functional change.

> --- a/mm/bounce.c
> +++ b/mm/bounce.c
> @@ -3,6 +3,8 @@
> * - Split from highmem.c
> */
>
> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

Because of this.

> #include <linux/mm.h>
> #include <linux/export.h>
> #include <linux/swap.h>
> @@ -15,6 +17,7 @@
> #include <linux/hash.h>
> #include <linux/highmem.h>
> #include <linux/bootmem.h>
> +#include <linux/printk.h>
> #include <asm/tlbflush.h>
>
> #include <trace/events/block.h>
> @@ -34,7 +37,7 @@ static __init int init_emergency_pool(void)
>
> page_pool = mempool_create_page_pool(POOL_SIZE, 0);
> BUG_ON(!page_pool);
> - printk("bounce pool size: %d pages\n", POOL_SIZE);
> + pr_info("bounce pool size: %d pages\n", POOL_SIZE);

This used to print "bounce pool size: N pages" but will now print
"bounce: bounce pool size: N pages".

It isn't necessarily a *bad* change but perhaps a little more thought
could be put into it. In this example it would be better remove the
redundancy by using

pr_info("pool size: %d pages\n"...);

And all of this should be described and justified in the changelog,
please.




\
 
 \ /
  Last update: 2014-04-15 01:41    [W:0.119 / U:0.176 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site