| Date | Mon, 14 Apr 2014 12:38:17 -0700 | From | Stephen Boyd <> | Subject | Re: [PATCH 18/38] tick-common: don't set mode to CLOCK_EVT_MODE_UNUSED in tick_shutdown() |
| |
On 04/14/14 09:23, Viresh Kumar wrote: > tick_shutdown() calls clockevents_exchange_device() which already sets mode to > CLOCK_EVT_MODE_UNUSED
Yes it does.
> and so tick_shutdown() doesn't need to do it. > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > --- > kernel/time/tick-common.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/kernel/time/tick-common.c b/kernel/time/tick-common.c > index bb9a218..3954f4d 100644 > --- a/kernel/time/tick-common.c > +++ b/kernel/time/tick-common.c > @@ -334,7 +334,6 @@ void tick_shutdown(unsigned int *cpup) > * Prevent that the clock events layer tries to call > * the set mode function! > */ > - dev->mode = CLOCK_EVT_MODE_UNUSED;
But see the comment above this assignment. The point is to avoid calling the ->set_mode function.
> clockevents_exchange_device(dev, NULL); > dev->event_handler = clockevents_handle_noop; > td->evtdev = NULL;
-- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
|