lkml.org 
[lkml]   [2014]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH V3 1/1] X86: Probe for PIC and set legacy_pic appropriately
Date


> -----Original Message-----
> From: H. Peter Anvin [mailto:hpa@zytor.com]
> Sent: Monday, April 14, 2014 10:02 AM
> To: KY Srinivasan; x86@kernel.org; gregkh@linuxfoundation.org; linux-
> kernel@vger.kernel.org; devel@linuxdriverproject.org; olaf@aepfle.de;
> apw@canonical.com; jasowang@redhat.com; tglx@linutronix.de;
> JBeulich@suse.com
> Subject: Re: [PATCH V3 1/1] X86: Probe for PIC and set legacy_pic
> appropriately
>
> On 04/14/2014 10:46 AM, K. Y. Srinivasan wrote:
> > This patch implements the proposal put forth by H. Peter Anvin
> <hpa@linux.intel.com>.
> >
> > In version V1 of the patch, I had cleaned up the code based on comments
> from Peter.
> > In version V2 of the patch, I have addressed additional comments from
> Peter.
> > In this version of the patch, I have addressed Jan's comments
> (JBeulich@suse.com).
> >
> > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
>
> Technically the patch looks good, but I'm going to have to reject it based on
> the patch description.
>
> Keep in mind that the above description is the only thing that would go into
> the git repository, and needs to be understandable to someone, say,
> 10 years from now.
>
> The above says nothing about what the proposal was, and the motivation,
> and the problems it addresses. So the patch is good, but please write a
> proper, standalone description for it.

Thanks Peter; I will update the description and send it out soon.

K. Y
>
> Thanks,
>
> -hpa
>



\
 
 \ /
  Last update: 2014-04-14 19:41    [W:0.059 / U:0.660 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site