Messages in this thread | | | Date | Sun, 13 Apr 2014 22:43:49 +0200 | Subject | Re: [RFC] QR encoding for Oops messages | From | Levente Kurusa <> |
| |
Hi,
2014-04-08 19:29 GMT+02:00 Levente Kurusa <levex@linux.com>: > Hi, > > On 04/08/2014 07:20 PM, Jason Cooper wrote: >> On Tue, Apr 08, 2014 at 05:42:00PM +0200, Levente Kurusa wrote: >>> On 04/07/2014 05:20 PM, Jason Cooper wrote: >>>> On Sat, Apr 05, 2014 at 11:11:02AM +0200, Levente Kurusa wrote: >>>>> Oh and another suggestion, I think placing it in the bottom-right >>>>> corner would be better since then we wouldn't overwrite some of >>>>> the timestamps and messages. >>>> >>>> The real text is still sent to the (hopefully written to disk) logs. If >>>> a user (or distro) builds with this feature, I would think centered and >>>> scaled for ease of scanning would be highest priority. >>> >>> Yup, I'll be traveling on the train a lot this week, so I'll >>> have plenty of time to implement scaling and centering. Maybe >>> we could also implement this: >>> >>> qr_oops=center (center the QR code with scale 1) >>> qr_oops=center,3 (center the QR code with scale 3) >>> >>> 'center' could also be 'topleft', 'bottomright', etc. >>> Or just remain at the KISS rule? (keep it simple) >>> >>> Any objections? >> >> KISS. ;-) >> >> Iff we find we need the feature later, we can always add qr_oops_pos or >> similar. >> > > Alright, I'll start the work on that tomorrow. > > Maybe I'll also find some time to clean up the library, > since I guess that should be our primary priority.
Just a quick reminder that scaling was just merged in [0]. I'd highly appreciate feedback. Thanks!
Now that rendering is a bit cleaner I'll start cleaning up the library. This is what I intend to do next week:
* Extract bitstream.c into a new kernel library. No point in restricting this to QR only.
* Rework bitstream to propagate errors, to use a caller allocation scheme and remove the ugly OOPness.
* Fix up the QR library so that it propagates errors from the new bitstream code.
Any objections?
[0]: https://github.com/teobaluta/qr-linux-kernel/commit/70401a9918e0810e7b0784fa6e1bdc766df20352
-- Regards, Levente Kurusa PGP: 4EF5D641
| |