Messages in this thread | | | Date | Sun, 13 Apr 2014 08:48:32 -0400 | From | Paolo Bonzini <> | Subject | Re: [RFC PATCH v2 6/6] KVM: emulate: remove memopp and rip_relative |
| |
Il 10/04/2014 20:03, Bandan Das ha scritto: > /* Fields above regs are cleared together. */
This comment is not accurate anymore after patch 4. Since you're fixing it, please add another comment saying where the cleared fields start, too.
> + ctxt->memop.addr.mem.ea = (u32)ctxt->memop.addr.mem.ea;
This is missing "if (ctxt->ad_bytes != 8)".
> + if (rip_relative) > + ctxt->memop.addr.mem.ea += ctxt->_eip;
Paolo
| |