lkml.org 
[lkml]   [2014]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH v2 6/6] KVM: emulate: remove memopp and rip_relative
Il 10/04/2014 20:03, Bandan Das ha scritto:
> /* Fields above regs are cleared together. */

This comment is not accurate anymore after patch 4. Since you're fixing
it, please add another comment saying where the cleared fields start, too.

> + ctxt->memop.addr.mem.ea = (u32)ctxt->memop.addr.mem.ea;

This is missing "if (ctxt->ad_bytes != 8)".

> + if (rip_relative)
> + ctxt->memop.addr.mem.ea += ctxt->_eip;

Paolo


\
 
 \ /
  Last update: 2014-04-13 15:01    [W:0.101 / U:1.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site