Messages in this thread | | | Subject | Re: [PATCH 1/1] kernel/rcu/tree.c: remove duplicate extern definition | From | Joe Perches <> | Date | Sun, 13 Apr 2014 20:18:00 -0700 |
| |
On Sun, 2014-04-13 at 23:03 -0400, Pranith Kumar wrote: > On Sun, Apr 13, 2014 at 10:50 PM, Joe Perches <joe@perches.com> wrote: > >> -/* > >> - * This function really isn't for public consumption, but RCU is special in > >> - * that context switches can allow the state machine to make progress. > >> - */ > >> -extern void resched_cpu(int cpu); > > > > why not #include "sched.h" > > and remove both declarations? > As the comment mentions, resched_cpu is internal to the scheduler and > hence is in sched/sched.h file and not in linux/sched.h.
Note the use of quotes and lack of angle brackets.
> sched/sched.h cannot be included in other subsystems directly.
If functions from it can be declared extern, then likely it could be used in an #include.
| |