lkml.org 
[lkml]   [2014]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mm: pass VM_BUG_ON() reason to dump_page()
On Fri, Apr 11, 2014 at 01:21:25PM -0700, Dave Hansen wrote:
>
> From: Dave Hansen <dave.hansen@linux.intel.com>
>
> I recently added a patch to let folks pass a "reason" string
> dump_page() which gets dumped out along with the page's data.
> This essentially saves the bug-reader a trip in to the source
> to figure out why we BUG_ON()'d.
>
> The new VM_BUG_ON_PAGE() passes in NULL for "reason". It seems
> like we might as well pass the BUG_ON() condition if we have it.
> This will bloat kernels a bit with ~160 new strings, but this
> is all under a debugging option anyway.
>
> page:ffffea0008560280 count:1 mapcount:0 mapping:(null) index:0x0
> page flags: 0xbfffc0000000001(locked)
> page dumped because: VM_BUG_ON_PAGE(PageLocked(page))
> ------------[ cut here ]------------
> kernel BUG at /home/davehans/linux.git/mm/filemap.c:464!
> invalid opcode: 0000 [#1] SMP
> CPU: 0 PID: 1 Comm: swapper/0 Not tainted 3.14.0+ #251
> Hardware name: Bochs Bochs, BIOS Bochs 01/01/2011
> ...
>
>
> Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>

I see space-before-tabs in few places, otherwise:

Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>

--
Kirill A. Shutemov


\
 
 \ /
  Last update: 2014-04-11 22:41    [W:0.030 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site