lkml.org 
[lkml]   [2014]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH 51/55] scsi: Move prototype declaration to header file megaraid/megaraid_sas_fusion.h from megaraid/megaraid_sas_base.c
    Date


    >-----Original Message-----
    >From: Rashika Kheria [mailto:rashika.kheria@gmail.com]
    >Sent: Sunday, March 30, 2014 12:18 AM
    >To: linux-kernel@vger.kernel.org
    >Cc: DL-MegaRAID Linux; James E.J. Bottomley; linux-scsi@vger.kernel.org;
    >josh@joshtriplett.org
    >Subject: [PATCH 51/55] scsi: Move prototype declaration to header file
    >megaraid/megaraid_sas_fusion.h from megaraid/megaraid_sas_base.c
    >
    >Move prototype declarations of functions to header file
    >megaraid/megaraid_sas_fusion.h from megaraid/megaraid_sas_base.c
    >because they are used by more than one file.
    >
    >This eliminates the following type of warnings in
    >megaraid/megaraid_sas_fusion.c:
    >drivers/scsi/megaraid/megaraid_sas_fusion.c:2170:1: warning: no previous
    >prototype for ‘megasas_release_fusion’ [-Wmissing-prototypes]
    >
    >Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
    >Reviewed-by: Josh Triplett <josh@joshtriplett.org>
    >---
    > drivers/scsi/megaraid/megaraid_sas_base.c | 13 -------------
    > drivers/scsi/megaraid/megaraid_sas_fusion.h | 14 ++++++++++++++
    > 2 files changed, 14 insertions(+), 13 deletions(-)
    >
    >diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c
    >b/drivers/scsi/megaraid/megaraid_sas_base.c
    >index 9768deee..0ad386b 100644
    >--- a/drivers/scsi/megaraid/megaraid_sas_base.c
    >+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
    >@@ -160,21 +160,8 @@ u32
    > megasas_build_and_issue_cmd(struct megasas_instance *instance,
    > struct scsi_cmnd *scmd);
    > static void megasas_complete_cmd_dpc(unsigned long instance_addr); -void
    >-megasas_release_fusion(struct megasas_instance *instance); -int -
    >megasas_ioc_init_fusion(struct megasas_instance *instance); -void -
    >megasas_free_cmds_fusion(struct megasas_instance *instance);
    >-u8
    >-megasas_get_map_info(struct megasas_instance *instance); -int -
    >megasas_sync_map_info(struct megasas_instance *instance); int
    >wait_and_poll(struct megasas_instance *instance, struct megasas_cmd
    >*cmd); -void megasas_reset_reply_desc(struct megasas_instance *instance);
    >-int megasas_reset_fusion(struct Scsi_Host *shost); -void
    >megasas_fusion_ocr_wq(struct work_struct *work);
    >
    > static void
    > megasas_issue_dcmd(struct megasas_instance *instance, struct
    >megasas_cmd *cmd) diff --git
    >a/drivers/scsi/megaraid/megaraid_sas_fusion.h
    >b/drivers/scsi/megaraid/megaraid_sas_fusion.h
    >index 35a5139..01e5ab3 100644
    >--- a/drivers/scsi/megaraid/megaraid_sas_fusion.h
    >+++ b/drivers/scsi/megaraid/megaraid_sas_fusion.h
    >@@ -760,4 +760,18 @@ union desc_value {
    > } u;
    > };
    >
    >+void
    >+megasas_release_fusion(struct megasas_instance *instance); int
    >+megasas_ioc_init_fusion(struct megasas_instance *instance); void
    >+megasas_free_cmds_fusion(struct megasas_instance *instance);
    >+u8
    >+megasas_get_map_info(struct megasas_instance *instance); int
    >+megasas_sync_map_info(struct megasas_instance *instance); void
    >+megasas_reset_reply_desc(struct megasas_instance *instance); int
    >+megasas_reset_fusion(struct Scsi_Host *shost); void
    >+megasas_fusion_ocr_wq(struct work_struct *work);
    >+
    > #endif /* _MEGARAID_SAS_FUSION_H_ */

    Acked-by: Sumit Saxena <sumit.saxena@lsi.com>

    -Sumit
    >--
    >1.7.9.5
    >

    \
     
     \ /
      Last update: 2014-04-11 08:41    [W:4.046 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site