lkml.org 
[lkml]   [2014]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ALSA: pcm: 'BUG:' message unnecessarily triggers kerneloops
At Thu, 10 Apr 2014 10:45:08 -0600,
Tim Gardner wrote:
>
> BugLink: http://bugs.launchpad.net/bugs/1305480
>
> The kerneloops-daemon scans dmesg for common crash signatures, among
> which is 'BUG:'. The message emitted by the PCM library is really a
> warning, so the most expedient thing to do seems to be to change the
> string.
>
> Cc: Jaroslav Kysela <perex@perex.cz>
> Cc: Takashi Iwai <tiwai@suse.de>
> Cc: Mark Brown <broonie@linaro.org>
> Cc: Lars-Peter Clausen <lars@metafoo.de>
> Cc: JongHo Kim <furmuwon@gmail.com>
> Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
> ---
> sound/core/pcm_lib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/core/pcm_lib.c b/sound/core/pcm_lib.c
> index ce83def..2a0563d 100644
> --- a/sound/core/pcm_lib.c
> +++ b/sound/core/pcm_lib.c
> @@ -345,7 +345,7 @@ static int snd_pcm_update_hw_ptr0(struct snd_pcm_substream *substream,
> snd_pcm_debug_name(substream, name, sizeof(name));
> xrun_log_show(substream);
> pcm_err(substream->pcm,
> - "BUG: %s, pos = %ld, buffer size = %ld, period size = %ld\n",
> + "OVER RUN: %s, pos = %ld, buffer size = %ld, period size = %ld\n",

Use a term "XRUN", as it's not always an overrun.


thanks,

Takashi


\
 
 \ /
  Last update: 2014-04-11 17:41    [W:0.055 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site