lkml.org 
[lkml]   [2014]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/4 v2] perf: Allow ability to map cpus to nodes easily
On Thu, Apr 10, 2014 at 09:15:15AM -0400, Don Zickus wrote:
> On Thu, Apr 10, 2014 at 11:31:46AM +0200, Jiri Olsa wrote:
> > On Mon, Apr 07, 2014 at 02:55:21PM -0400, Don Zickus wrote:
> >
> > SNIP
> >
> > > +static int init_cpunode_map(void)
> > > +{
> > > + int i;
> > > +
> > > + set_max_cpu_num();
> > > + set_max_node_num();
> > > +
> > > + cpunode_map = calloc(max_cpu_num, sizeof(int));
> > > + if (!cpunode_map) {
> > > + pr_err("%s: calloc failed\n", __func__);
> > > + goto out;
> > shuld probably be ^^^:
> >
> > return -1;
> >
> > > + }
> > > +
> > > + for (i = 0; i < max_cpu_num; i++)
> > > + cpunode_map[i] = -1;
> > > +
> > > + return 0;
> > > +out:
> > > + return -1;
> >
> > and remove 'out' label code
>
> Sorry, probably leftover code that after snipping and changing didn't get
> noticed. Thanks.
>
> >
> > other than that, it seems ok.. I'll queue it
>
> I assume you are making the changes locally or should I resubmit?

yes, I'll do that localy

jirka


\
 
 \ /
  Last update: 2014-04-11 00:41    [W:0.075 / U:4.464 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site