Messages in this thread | | | Subject | Re: [PATCH 03/15] ipc:sem.c #include <linux/uaccess.h> | From | Davidlohr Bueso <> | Date | Thu, 10 Apr 2014 14:51:51 -0700 |
| |
On Thu, 2014-04-10 at 14:49 -0700, Davidlohr Bueso wrote: > On Thu, 2014-04-10 at 19:45 +0100, Paul McQuade wrote: > > WARNING: Use #include <linux/uaccess.h> instead of <asm/uaccess.h> > > Nit: the subject should be less code and more text, something like "do > not include asm uaccess directly" or "replace <asm/uaccess.h> by > <linux/uaccess.h>" > > Curious, how are you seeing these warnings? > > Also, while at it we should probably get rid of the rest in ipc/: > > compat.c:#include <asm/uaccess.h> > compat_mq.c:#include <asm/uaccess.h> > msg.c:#include <asm/uaccess.h> > sem.c:#include <asm/uaccess.h> > shm.c:#include <asm/uaccess.h>
*sigh* you did but didn't maintain the CCs. It would make a lot more sense to keep it in the same patch.
| |