lkml.org 
[lkml]   [2014]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 05/13] extcon: extcon-class: improve extcon client API
Hi,

On Thu, Apr 10, 2014 at 03:16:43PM +0200, Robert Baldyga wrote:
> +struct extcon_cable *extcon_get_cable_by_name(struct device *dev,
> + const char *name)
> +{
> + return of_extcon_get_cable_by_name(dev->of_node, name);
> +}
> +EXPORT_SYMBOL_GPL(extcon_get_cable_by_name);

[...]

> @@ -96,17 +95,13 @@ static int omap_otg_probe(struct platform_device *pdev)
> {
> const struct omap_usb_config *config = pdev->dev.platform_data;
^^^^^^^^^^^^^

[...]

> - ret = extcon_register_interest(&otg_dev->id_dev, config->extcon,
> - "USB-HOST", &otg_dev->id_nb);
> + cable_id = extcon_get_cable_by_name(&pdev->dev, "USB-HOST");

NACK. OMAP1 is not using DT, so this driver would stop working
with this series.

A.


\
 
 \ /
  Last update: 2014-04-10 20:41    [W:0.117 / U:1.708 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site