Messages in this thread | | | Date | Thu, 10 Apr 2014 08:16:20 +0200 | From | Johannes Thumshirn <> | Subject | Re: [PATCH] drivers: mcb: fix memory leak in chameleon_parse_cells() error path |
| |
On Fri, Apr 04, 2014 at 09:04:58PM +0200, Christoph Jaeger wrote: > chameleon_parse_cells() bails out if chameleon descriptor type is > invalid but does not free the storage 'header' points to. > > Signed-off-by: Christoph Jaeger <christophjaeger@linux.com> > --- > drivers/mcb/mcb-parse.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mcb/mcb-parse.c b/drivers/mcb/mcb-parse.c > index d1278b5..0049269 100644 > --- a/drivers/mcb/mcb-parse.c > +++ b/drivers/mcb/mcb-parse.c > @@ -141,6 +141,7 @@ int chameleon_parse_cells(struct mcb_bus *bus, phys_addr_t mapbase, > default: > pr_err("Invalid chameleon descriptor type 0x%x\n", > dtype); > + kfree(header); > return -EINVAL; > } > num_cells++; > -- > 1.9.0 >
Hi,
Your patch has been applied to my repo located at:
https://github.com/morbidrsa/linux/tree/mcb
or
git://github.com/morbidrsa/linux.git
Thanks, Johannes
| |