lkml.org 
[lkml]   [2014]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] spi: core: Increase timeout value
On Thu, Apr 10, 2014 at 06:20:29PM +0530, Harini Katakam wrote:

> Considering acceptable latencies, this timeout can be set to a large
> value >= 1*HZ typically.

> This patch adds a tolerance of 2000 msec in the core accordingly.

That's too much, it's 2 seconds which gets to be incredibly painful when
trying to debug problems - if you're sitting there waiting for a driver
to time out some operations (and it may be more than one of them) so you
can look at the diagnostics it can be quite aggrivating. That's why the
delays are related to the expected runtime for the operation. Something
like double the expected runtime plus something in the 100ms or so range
perhaps?

Ideally we'd use the actual speed the device set rather than the
requested one too, that'd help.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2014-04-10 20:21    [W:0.087 / U:21.400 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site