lkml.org 
[lkml]   [2014]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v7 18/22] xip: Add xip_zero_page_range
On Wed, Apr 09, 2014 at 12:15:12PM +0200, Jan Kara wrote:
> > + /*
> > + * ext4 sometimes asks to zero past the end of a block. It
> > + * really just wants to zero to the end of the block.
> > + */
> Then we should really fix ext4 I believe...

Since I didn't want to do this ...

> > +/* Can't be a function because PAGE_CACHE_SIZE is defined in pagemap.h */
> > +#define dax_truncate_page(inode, from, get_block) \
> > + dax_zero_page_range(inode, from, PAGE_CACHE_SIZE, get_block)
> ^^^^
> This should be (PAGE_CACHE_SIZE - (from & (PAGE_CACHE_SIZE - 1))), shouldn't it?

... I could get away without doing that ;-)


\
 
 \ /
  Last update: 2014-04-10 17:01    [W:0.125 / U:16.180 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site