lkml.org 
[lkml]   [2014]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/4 v2] perf: Allow ability to map cpus to nodes easily
On Mon, Apr 07, 2014 at 02:55:21PM -0400, Don Zickus wrote:

SNIP

> +static int init_cpunode_map(void)
> +{
> + int i;
> +
> + set_max_cpu_num();
> + set_max_node_num();
> +
> + cpunode_map = calloc(max_cpu_num, sizeof(int));
> + if (!cpunode_map) {
> + pr_err("%s: calloc failed\n", __func__);
> + goto out;
shuld probably be ^^^:

return -1;

> + }
> +
> + for (i = 0; i < max_cpu_num; i++)
> + cpunode_map[i] = -1;
> +
> + return 0;
> +out:
> + return -1;

and remove 'out' label code

other than that, it seems ok.. I'll queue it

thanks,
jirka


\
 
 \ /
  Last update: 2014-04-10 12:41    [W:0.110 / U:23.384 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site