Messages in this thread | | | Date | Wed, 2 Apr 2014 08:26:18 +0800 | Subject | Re: [PATCH v2 1/2] regulator: pbias: Fix is_enabled callback implementation | From | Axel Lin <> |
| |
2014-03-08 11:55 GMT+08:00 Axel Lin <axel.lin@ingics.com>: > The is_enabled implementation is wrong in some cases: > e.g. for pbias_mmc_omap5: enable_mask is : BIT(27) | BIT(25) | BIT(26) > However, pbias_regulator_enable() only sets BIT(27) | BIT(26) bits. > So is_enabled callback will always return false in this case. > Fix the logic to compare the register value with info->enable rather than > info->enable_mask. >
Hi Chris, Would you pick up this patch serial?
Regards, Axel
| |