lkml.org 
[lkml]   [2014]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/3] staging: vt6655: fix DBG_PRT and PRINT_K macros
    On Tue, Apr 01, 2014 at 09:52:11AM -0300, Guido Martínez wrote:
    > Parenthesize both macros so they will not break program logic if used
    > within another 'if'. Also fix a usage of DBG_PRT with a missing
    > semicolon.
    >
    > Signed-off-by: Guido Martínez <guido@vanguardiasur.com.ar>
    > ---
    > drivers/staging/vt6655/device.h | 4 ++--
    > drivers/staging/vt6655/wpactl.c | 2 +-
    > 2 files changed, 3 insertions(+), 3 deletions(-)
    >
    > diff --git a/drivers/staging/vt6655/device.h b/drivers/staging/vt6655/device.h
    > index 062c3a3..483b017 100644
    > --- a/drivers/staging/vt6655/device.h
    > +++ b/drivers/staging/vt6655/device.h
    > @@ -148,8 +148,8 @@
    >
    > /*--------------------- Export Types ------------------------------*/
    >
    > -#define DBG_PRT(l, p, args...) { if (l <= msglevel) printk(p, ##args); }
    > -#define PRINT_K(p, args...) { if (PRIVATE_Message) printk(p, ##args); }
    > +#define DBG_PRT(l, p, args...) ({ if (l <= msglevel) printk(p, ##args); })
    > +#define PRINT_K(p, args...) ({ if (PRIVATE_Message) printk(p, ##args); })

    I would much rather see these "fixed" by removing them entirely and
    using the in-kernel calls instead (netdev_* and dev_* where applicable.)

    thanks,

    greg k-h
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2014-04-01 19:22    [W:4.131 / U:0.248 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site